Bump sdkcompat integration test to target SDK 29 (Q)

Previously it targeted SDK 28 (P), but at this point it is okay to expect that the min supported compile SDK is Q.
robolectric · Apr 26, 2024 · e2a8e26 · e2a8e26
1 parent d440248
commit e2a8e26
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/integration_tests/sdkcompat/build.gradle b/integration_tests/sdkcompat/build.gradle
@@ -14,13 +14,13 @@ spotless {
 }
 
 android {
-    compileSdk 28
+    compileSdk 29
     namespace 'org.robolectric.integrationtests.sdkcompat'
 
     defaultConfig {
         minSdk 19
-        // We must keep targetSdk to 28 for compatibility testing purpose
-        targetSdk 28
+        // We must keep targetSdk to 29 for compatibility testing purpose
+        targetSdk 29
     }
 
     compileOptions {

diff --git a/integration_tests/sdkcompat/src/main/AndroidManifest.xml b/integration_tests/sdkcompat/src/main/AndroidManifest.xml
@@ -3,5 +3,5 @@
     xmlns:android="http://schemas.android.com/apk/res/android">
     <application
         android:appComponentFactory="org.robolectric.integrationtests.sdkcompat.TestAppComponentFactory"
-        tools:targetApi="p" />
+        tools:targetApi="q" />
 </manifest>
diff --git a/...st/java/org/robolectric/integrationtests/sdkcompat/JavaClassResolveCompatibilityTest.java b/...st/java/org/robolectric/integrationtests/sdkcompat/JavaClassResolveCompatibilityTest.java
@@ -14,8 +14,8 @@
 @RunWith(RobolectricTestRunner.class)
 public class JavaClassResolveCompatibilityTest {
   @Test
-  public void sdkIs28() {
-    assertThat(Build.VERSION.SDK_INT).isEqualTo(Build.VERSION_CODES.P);
+  public void sdkIs29() {
+    assertThat(Build.VERSION.SDK_INT).isEqualTo(Build.VERSION_CODES.Q);
   }
 
   @Test

diff --git a/...ompat/src/test/java/org/robolectric/integrationtests/sdkcompat/NormalCompatibilityTest.kt b/...ompat/src/test/java/org/robolectric/integrationtests/sdkcompat/NormalCompatibilityTest.kt
@@ -27,8 +27,8 @@ class NormalCompatibilityTest {
   private val application = RuntimeEnvironment.getApplication()
 
   @Test
-  fun `Environment SDK is 28`() {
-    assertThat(Build.VERSION.SDK_INT).isEqualTo(Build.VERSION_CODES.P)
+  fun `Environment SDK is 29`() {
+    assertThat(Build.VERSION.SDK_INT).isEqualTo(Build.VERSION_CODES.Q)
   }
 
   @Test

diff --git a/integration_tests/sdkcompat/src/test/resources/robolectric.properties b/integration_tests/sdkcompat/src/test/resources/robolectric.properties
@@ -1 +1 @@
-sdk=28
+sdk=29