Skip to content

Commit

Permalink
Fix broken GitHub CI when running tests
Browse files Browse the repository at this point in the history
The cache key to restore ICU was incorrect when running
tests.
  • Loading branch information
hoisie committed Nov 29, 2021
1 parent c390033 commit b6953a0
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/tests.yml
Expand Up @@ -53,7 +53,7 @@ jobs:
make install
- name: Build
run: ICU_ROOT_DIR=$HOME/icu-bin SKIP_ICU_BUILD=true SKIP_ERRORPRONE=true SKIP_JAVADOC=true ./gradlew clean assemble testClasses --parallel --stacktrace --no-watch-fs
run: ICU_ROOT_DIR=$HOME/icu-bin SKIP_ICU_BUILD=true SKIP_ERRORPRONE=true SKIP_JAVADOC=true ./gradlew clean assemble testClasses --parallel --stacktrace --no-watch-fs

unit-tests:
runs-on: ubuntu-18.04
Expand Down Expand Up @@ -82,12 +82,16 @@ jobs:
with:
java-version: 11.0.8

- name: Detect runner CPU architecture
run: |
echo "CPU_ARCH=$(uname -m)" >> $GITHUB_ENV
- name: Cache ICU build output
id: cache-icu
uses: actions/cache@v2
with:
path: ~/icu-bin
key: ${{ runner.os }}-icu-${{ hashFiles('nativeruntime/external/icu/**') }}
key: ${{ runner.os }}-${{env.CPU_ARCH}}-icu-${{ hashFiles('nativeruntime/external/icu/**') }}

- name: Run unit tests
run: |
Expand Down

0 comments on commit b6953a0

Please sign in to comment.