Issue checkstyle#6320: added REMOVE_CONDITIONALS mutator for sizes

rnveach · Dec 28, 2018 · 8987dfe · 8987dfe
1 parent e1ad26b
commit 8987dfe
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/pom.xml b/pom.xml
@@ -2390,6 +2390,7 @@
                 <mutator>INVERT_NEGS</mutator>
                 <mutator>MATH</mutator>
                 <mutator>NEGATE_CONDITIONALS</mutator>
+                <mutator>REMOVE_CONDITIONALS</mutator>
                 <mutator>RETURN_VALS</mutator>
                 <mutator>TRUE_RETURNS</mutator>
                 <mutator>VOID_METHOD_CALLS</mutator>

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/ParameterNumberCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/ParameterNumberCheckTest.java
@@ -105,7 +105,7 @@ public void shouldLogActualParameterNumber()
     }
 
     @Test
-    public void shouldIgnoreMethodsWithOverrideAnnotation()
+    public void testIgnoreOverriddenMethods()
             throws Exception {
         final DefaultConfiguration checkConfig =
                 createModuleConfig(ParameterNumberCheck.class);
@@ -117,4 +117,18 @@ public void shouldIgnoreMethodsWithOverrideAnnotation()
         verify(checkConfig, getPath("InputParameterNumber.java"), expected);
     }
 
+    @Test
+    public void testIgnoreOverriddenMethodsFalse()
+            throws Exception {
+        final DefaultConfiguration checkConfig =
+                createModuleConfig(ParameterNumberCheck.class);
+        final String[] expected = {
+            "6:10: " + getCheckMessage(MSG_KEY, 7, 8),
+            "11:10: " + getCheckMessage(MSG_KEY, 7, 8),
+            "19:10: " + getCheckMessage(MSG_KEY, 7, 8),
+            "24:10: " + getCheckMessage(MSG_KEY, 7, 8),
+        };
+        verify(checkConfig, getPath("InputParameterNumber.java"), expected);
+    }
+
 }
diff --git a/...tools/checkstyle/checks/sizes/executablestatementcount/InputExecutableStatementCount.java b/...tools/checkstyle/checks/sizes/executablestatementcount/InputExecutableStatementCount.java
@@ -86,4 +86,8 @@ public void run() {
 
     /** Empty constructor */
     public InputExecutableStatementCount(String someString) {}
+
+    static Runnable r1 = () -> {
+        String.valueOf("Hello world one!");
+    };
 }