Revert "Issue checkstyle#11604: allows 3rd parties to expand module i…

…dentification" This reverts commit 89ece36.
rnveach · Oct 20, 2022 · 2c39b28 · 2c39b28
1 parent 89ece36
commit 2c39b28
Show file tree

Hide file tree

Showing 5 changed files with 83 additions and 91 deletions.
diff --git a/.ci/pitest-suppressions/pitest-utils-suppressions.xml b/.ci/pitest-suppressions/pitest-utils-suppressions.xml
@@ -633,19 +633,73 @@
   <mutation unstable="false">
     <sourceFile>ModuleReflectionUtil.java</sourceFile>
     <mutatedClass>com.puppycrawl.tools.checkstyle.utils.ModuleReflectionUtil</mutatedClass>
-    <mutatedMethod>addNewModuleIdentification</mutatedMethod>
+    <mutatedMethod>getCheckstyleModules</mutatedMethod>
     <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
-    <description>replaced call to java/util/function/Predicate::or with receiver</description>
-    <lineContent>identificationPredicate = newPredicate.or(identificationPredicate);</lineContent>
+    <description>replaced call to java/util/stream/Stream::filter with receiver</description>
+    <lineContent>.filter(ModuleReflectionUtil::isCheckstyleModule)</lineContent>
   </mutation>
 
   <mutation unstable="false">
     <sourceFile>ModuleReflectionUtil.java</sourceFile>
     <mutatedClass>com.puppycrawl.tools.checkstyle.utils.ModuleReflectionUtil</mutatedClass>
-    <mutatedMethod>getCheckstyleModules</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
-    <description>replaced call to java/util/stream/Stream::filter with receiver</description>
-    <lineContent>.filter(ModuleReflectionUtil::isCheckstyleModule)</lineContent>
+    <mutatedMethod>isCheckstyleModule</mutatedMethod>
+    <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
+    <description>removed conditional - replaced equality check with false</description>
+    <lineContent>&amp;&amp; (isCheckstyleTreeWalkerCheck(clazz)</lineContent>
+  </mutation>
+
+  <mutation unstable="false">
+    <sourceFile>ModuleReflectionUtil.java</sourceFile>
+    <mutatedClass>com.puppycrawl.tools.checkstyle.utils.ModuleReflectionUtil</mutatedClass>
+    <mutatedMethod>isCheckstyleModule</mutatedMethod>
+    <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
+    <description>removed conditional - replaced equality check with false</description>
+    <lineContent>|| isAuditListener(clazz)</lineContent>
+  </mutation>
+
+  <mutation unstable="false">
+    <sourceFile>ModuleReflectionUtil.java</sourceFile>
+    <mutatedClass>com.puppycrawl.tools.checkstyle.utils.ModuleReflectionUtil</mutatedClass>
+    <mutatedMethod>isCheckstyleModule</mutatedMethod>
+    <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
+    <description>removed conditional - replaced equality check with false</description>
+    <lineContent>|| isFileFilterModule(clazz)</lineContent>
+  </mutation>
+
+  <mutation unstable="false">
+    <sourceFile>ModuleReflectionUtil.java</sourceFile>
+    <mutatedClass>com.puppycrawl.tools.checkstyle.utils.ModuleReflectionUtil</mutatedClass>
+    <mutatedMethod>isCheckstyleModule</mutatedMethod>
+    <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
+    <description>removed conditional - replaced equality check with false</description>
+    <lineContent>|| isFileSetModule(clazz)</lineContent>
+  </mutation>
+
+  <mutation unstable="false">
+    <sourceFile>ModuleReflectionUtil.java</sourceFile>
+    <mutatedClass>com.puppycrawl.tools.checkstyle.utils.ModuleReflectionUtil</mutatedClass>
+    <mutatedMethod>isCheckstyleModule</mutatedMethod>
+    <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
+    <description>removed conditional - replaced equality check with false</description>
+    <lineContent>|| isFilterModule(clazz)</lineContent>
+  </mutation>
+
+  <mutation unstable="false">
+    <sourceFile>ModuleReflectionUtil.java</sourceFile>
+    <mutatedClass>com.puppycrawl.tools.checkstyle.utils.ModuleReflectionUtil</mutatedClass>
+    <mutatedMethod>isCheckstyleModule</mutatedMethod>
+    <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
+    <description>removed conditional - replaced equality check with true</description>
+    <lineContent>|| isRootModule(clazz));</lineContent>
+  </mutation>
+
+  <mutation unstable="false">
+    <sourceFile>ModuleReflectionUtil.java</sourceFile>
+    <mutatedClass>com.puppycrawl.tools.checkstyle.utils.ModuleReflectionUtil</mutatedClass>
+    <mutatedMethod>isCheckstyleModule</mutatedMethod>
+    <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
+    <description>removed conditional - replaced equality check with false</description>
+    <lineContent>|| isTreeWalkerFilterModule(clazz)</lineContent>
   </mutation>
 
   <mutation unstable="false">