Fix: Adds peerDependencies #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. Must admit, I hadn't heard of the pnp system but this doesn't seem to have any impact for those not using. I'll merge and push a release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR specifies peerDependencies of dependencies that are intended for the user to satisfy. This is required for pnp module resolution to function (yarn pnp, yarn berry - like in the PR for dependency knex knex/knex#3081). Without this this module doesn't work with yarn pnp (as the db driver cannot be required).
nb; nice module, it took me a few tries to find it but its great 馃槃