Add an option to reject numbers followed by names #4924
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4871
This option is off by default now but will be on by default in GraphQL-Ruby 3.0. You can opt into the new behavior with:
And you can check for invalid query strings using the helper:
TODO:
Also make sure variable definitions are covered, egquery($a: Int = 5$b: Int = 6) { ... }
@
or$
, not a name. I did add tests for input object literals, and they were covered by the current implementation.GraphQL.reject_numbers_followed_by_names = true