Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relation_count to avoid ordered count in has_next_page #4912

Closed
wants to merge 1 commit into from

Conversation

rmosolgo
Copy link
Owner

Fixes #4911

@rmosolgo rmosolgo added this to the 2.3.1 milestone Apr 11, 2024
@rmosolgo
Copy link
Owner Author

This is not right. As shown by the test failure, @nodes is already an Array at this point:

# Load nodes after applying first/last/before/after,
# returns an array of nodes
def load_nodes
# Return an array so we can consistently use `.index(node)` on it
@nodes ||= limited_nodes.to_a
end

@rmosolgo rmosolgo closed this Apr 15, 2024
@rmosolgo rmosolgo removed this from the 2.3.1 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to use ordered relation for count
1 participant