Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.13.x] require ostruct which was previously required by rake #4901

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Apr 5, 2024

Fixes #4900

Not needed in 2.x because the file using it isn't present.

There is another use of OpenStruct in the gem, but it will only run in applications which already use OpenStruct:

when OPEN_STRUCT_KEY
ostruct_values = load_value(value[OPEN_STRUCT_KEY])
OpenStruct.new(ostruct_values)

@rmosolgo rmosolgo added this to the 1.13.23 milestone Apr 5, 2024
@rmosolgo
Copy link
Owner Author

rmosolgo commented Apr 5, 2024

It looks like a lot of these builds have been failing for a while. I don't plan to dive into that yet ... but it fixed the bug in loading the gem, and the main test suite still passes 🍻

@rmosolgo rmosolgo merged commit 72c2a21 into 1.13.x Apr 5, 2024
3 of 12 checks passed
@rmosolgo rmosolgo deleted the require-ostruct branch April 5, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant