Reduce duplicated identifier strings in C parser and Ruby parser #4899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR dedups identifiers during parsing when parsing schemas.
A previous investigation (#4897) tried de-duping these in Schema members, but because AST nodes are retained along with the things that they define, these strings should be de-duplicated sooner, or else the originally-parsed strings will still be retained.
This greatly reduces retained strings in the benchmark:
I also updated the Ruby parser. It still allocates duplicate strings, but it doesn't retain them anymore:
TODO:
rb_enc_interned_str
breaks Ruby 2.7 compat. Is this OK? (2.7 is EOL)