Fix run_graphql_field with missing query string on dummy query #4891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: The
dummy_query
object created as part ofrun_graphql_field
doesn't set a query string, which results in aquery_context
object that has validation errors.Later when
object_type.wrap(inner_object, query_context)
is called with thatquery_context
, it checks that the field is authorized.If as part of checking
self.authorized?
on an object, we first ensure that the context is valid i.e. thatcontext.errors.empty?
, we will find that it isn't because of this missing query string.Even if this query string isn't used, the
GraphQL::Query
object should be valid, in case there are validations that are done on these objects in a client's code. This is what we are doing in our code, which led me to this bug.This PR sets a dummy query string value to fix this issue, and adds a simple
self.authorized?
check which ensures that the context is valid i.e. thatcontext.errors.empty?