New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directives not respecting warden: Add test failure #4882

Draft

tjoyal wants to merge 1 commit into rmosolgo:master from tjoyal:directives-not-respecting-warden

Contributor

tjoyal commented Mar 12, 2024

This test fails.

# Failure:
# GraphQL::Schema::Warden::hiding fields#test_0003_hides directives if no other fields are using it
# Minitest::Assertion: --- expected
# +++ actual
# @@ -1 +1 @@
# -["include", "skip", "deprecated", "oneOf", "specifiedBy"]
# +["include", "skip", "deprecated", "oneOf", "specifiedBy", "cheremeDirectives"]

I believe that an "unused directive" shouldn't be added to the schema, similar to how it's done for unused (invisible) types.

Is this indeed the desired behavior as I'm assuming it should be?

I'm not sure I have the right expertise in the gem internals to propose an appropriate fix...


          Add test failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment