Validate incoming orphan_types are object types #4869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The one slight edge case to this is an interface implementing another interface. This would make it more explicit when you have to pass orphan types from one interface to another. But I still believe this change is better because as is, it obscures how GraphQL actually works. To get around this, people could do |
|
I think this will be a bigger change than I realized -- I'm going to punt it back to 2.3.0. |
thomasmarshall
added a commit
to thomasmarshall/graphql-stitching-ruby
that referenced
this pull request
Apr 6, 2024
GraphQL Ruby 2.3.0 validates incoming orphan_types are object types [1]. One of the suggested fixes is to use `add_type_and_traverse` directly, though that is a private method and not guaranteed to always work. [1]: rmosolgo/graphql-ruby#4869
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4858
After this change, only Object types may be passed to
orphan_types(...). This is how it's supposed to work, although it may break some edge cases. The ways I addressed this in tests are:extra_types(...)to attach random types to the schemaadd_type_and_traverse(types, root: false), which is a private method and I can't guarantee it will always work. But it's the right thing for implementingSchema.load_from_definition, etc.