Fix current_depth method
#4386
Merged
Fix current_depth method
#4386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some circumstances, the `thread_info` object is empty, and there is no result. In such case, the method should return depth 1 instead of failing.
|
Hey, thanks for submitting this fix! I'm interested in including a test for this case to make sure I don't break it again in the future. Could you add a test case to this PR for it, or else share the stack trace of the error you encountered? (The stack trace would likely include enough info to replicate the bug.) |
|
@rmosolgo I would absolutely add a failing spec, but I honestly don't know what causes it. We use FWIW, here is a stacktrace from the spec: |
|
Ok, thanks, this helps -- it looks like it was resolving a list at the time. As for returning |
|
This is the minimum query that causes the failure in our spec: {
result: projectById(id: "#{project_id}") {
feasibilityReviews {
id
}
}
}I tried reproducing it by creating a stripped-down schema that uses the same loader and The loader used for this field looks like this: class RelationLoader < ::GraphQL::Batch::Loader
def initialize(relation:, column:)
super()
@relation = relation
@column = column
end
def perform(ids)
@relation.where(@column => ids).group_by(&@column).each do |id, records|
fulfill(id, records)
end
ids.each { |id| fulfill(id, []) unless fulfilled?(*id) }
end
endand it is used more or less like this: class ProjectType < GraphQL::Schema::Object
field :feasibility_reviews, [FeasibilityReviewType], null: false
def feasibility_reviews
RelationLoader.for(relation: Models::FeasibilityReview.where(reviewer_id: current_user.id), column: :project_id)
end
end |
|
Thanks for those details -- that's really helpful. I'll try to come up with a replication. Also, does |
|
It uses a regular ActiveRecord |
|
Cool, thanks for confirming. I can't figure out exactly what's wrong 😖 But I just pushed an alternative solution which simplifies the class a bit (by removing a method). Could you give that solution a try and see if it still fixes it for you, or if you still encounter an error (please share the message and backtrace if so)? |
|
Thank you @rmosolgo! I ran the specs and the fix works. |
|
Ok, thanks for checking into it. I'm afraid there's some other bug lurking here where some of the runtime context isn't set correctly 😖 But this will have to do for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some circumstances, the
thread_infoobject is empty, and there is no result. In such a case, the method should return depth 1 instead of failing.We ran into this problem after updating to
graphqlversion2.0.19(although it also happens in2.0.18).