1.13: lookup given hash_key: when possible #4286
Merged
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rmosolgo Thank you - this is what I was looking for! |
|
Great -- released to RubyGems in v1.13.18! |
|
🤦 🤦 🤦 Meanwhile, back in my terminal:
Amazingly, entering a live code hours later worked fine 😅 💁♂️ https://rubygems.org/gems/graphql/versions/1.13.18 Unfortunately that GitHub Action won't pass without a bit of work, since the workflow file is so old, so the docs won't get properly published... |
|
Thank you! I'll give it a try tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4072 (comment)
When a field is configured with
hash_key:, look up that key using[...], even if the underlying object isn't a Hash. (This code checks for.respond_to?(:[])to avoid breaking changes, which might be possible because of howhash_keywas previously merged intomethod_*attributes.)