Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow re-assigning Query#validate after validation #4127

Merged
merged 1 commit into from Jul 4, 2022

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Jul 4, 2022

Since recently, you could assign Query#validate=... to tell a query whether it should run static validation or not. But the validation result is cached, so it'd be buggy to reassign this afterward. I'd like to warn people about it rather that allow a possible foot-gun. If this doesn't work, this other option is to bust the validation cache whenever this value is reassigned.

Fixes #3901

@rmosolgo rmosolgo added this to the 2.0.11 milestone Jul 4, 2022
@rmosolgo rmosolgo merged commit ccd30db into master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise error if Query#validate is assigned a value after static validation is completed
1 participant