Don't allow re-assigning Query#validate after validation #4127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since recently, you could assign
Query#validate=...
to tell a query whether it should run static validation or not. But the validation result is cached, so it'd be buggy to reassign this afterward. I'd like to warn people about it rather that allow a possible foot-gun. If this doesn't work, this other option is to bust the validation cache whenever this value is reassigned.Fixes #3901