Fix RelationConnections when relation already has limit #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongRongTeng
force-pushed
the
fix-relations-with-existing-limit
branch
from
622088c
to
846fdd1
Compare
RongRongTeng
force-pushed
the
fix-relations-with-existing-limit
branch
2 times, most recently
from
246a730
to
15cac94
Compare
RongRongTeng
force-pushed
the
fix-relations-with-existing-limit
branch
from
15cac94
to
613b082
Compare
|
Thanks for the fix here! It looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found
with application-provided limitwill not be applied, and try to fix it 馃檹馃徎For example:
Connection using
first: 5, and when querying relation is limit to 2[Actual Result] It will return 5 nodes
[Expected Result] It will return only 2 nodes