Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default_page_size to schema, field, and resolver #4081

Merged
merged 9 commits into from May 31, 2022
Merged

Add default_page_size to schema, field, and resolver #4081

merged 9 commits into from May 31, 2022

Commits on May 30, 2022

  1. Add a basic implementation of default_page_size. 

    This is configurable on the field-level, resolver-level, and
schema-level. Also add some _very_ basic specs. I probably need to add
quite a few more than this.

I need to figure out whether the complexity calculation logic needs to
be updated to handle this. I also need to figure out whether to add
error handling for the case where max page size < default page size. And
I need to look into how to make `default_page_size: nil` actually return
an unbounded list (or scrap that idea entirely, I guess).
    @connorshea
    connorshea committed May 30, 2022
    Copy the full SHA
    803af92 View commit details
    Browse the repository at this point in the history

  2. Clamp the default_page_size value if it's greater than the max.

    @connorshea
    connorshea committed May 30, 2022
    Copy the full SHA
    ace4ff4 View commit details
    Browse the repository at this point in the history

  3. Update the ConnectionAssertions specs. 

    Set a default_page_size value and allow tests to override it via a query
parameter.
    @connorshea
    connorshea committed May 30, 2022
    Copy the full SHA
    0c96aba View commit details
    Browse the repository at this point in the history

  4. Update field complexity calculation logic. 

    Use default_page_size instead of max_page_size if default_page_size is
set either at the field or schema level. Also add a test for field-level
default_page_size.
    @connorshea
    connorshea committed May 30, 2022
    Copy the full SHA
    333aac9 View commit details
    Browse the repository at this point in the history

  5. Add test for schema-level default_page_size.

    @connorshea
    connorshea committed May 30, 2022
    Copy the full SHA
    1931dc8 View commit details
    Browse the repository at this point in the history

  6. Add some basic docs for default_page_size.

    @connorshea
    connorshea committed May 30, 2022
    Copy the full SHA
    2e72654 View commit details
    Browse the repository at this point in the history

  7. Update complexity docs for default_page_size.

    @connorshea
    connorshea committed May 30, 2022
    Copy the full SHA
    945415a View commit details
    Browse the repository at this point in the history

  8. Add specs for default_page_size on resolvers.

    @connorshea
    connorshea committed May 30, 2022
    Copy the full SHA
    fce8030 View commit details
    Browse the repository at this point in the history

  9. Update a failing spec.

    @connorshea
    connorshea committed May 30, 2022
    Copy the full SHA
    ae9c9ba View commit details
    Browse the repository at this point in the history