Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use fetch for fields that use hash_key #4060

Closed
wants to merge 9 commits into from
Closed

Don't use fetch for fields that use hash_key #4060

wants to merge 9 commits into from

Commits on May 4, 2022

  1. 🐛 Move the hash_keys call into Hash check 

    Co-authored-by: George Xu <george.xu@chime.com>
    @danielvdao @georgexu22
    danielvdao and georgexu22 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    059a5b7 View commit details
    Browse the repository at this point in the history

  2. 🐛 move it back and use something safer. 

    Co-authored-by: georgexu22@chime.com
    @danielvdao
    danielvdao committed May 4, 2022
    Configuration menu
    Copy the full SHA
    30711e0 View commit details
    Browse the repository at this point in the history

  3. Fix the bug by using nil key check, Co-authored-by: George Xu <george… 

    ….xu@chime.com>
    @danielvdao
    danielvdao committed May 4, 2022
    Configuration menu
    Copy the full SHA
    3a66727 View commit details
    Browse the repository at this point in the history

  4. 🐛 Move it back to being a bit safer. 

    Co-authored-by: George Xu <george.xu@chime.com>
    @danielvdao @georgexu22
    danielvdao and georgexu22 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    4e9e3f9 View commit details
    Browse the repository at this point in the history

  5. ⏪ revert accidental changes 

    Co-authored-by: georgexu22@chime.com
    @danielvdao
    danielvdao committed May 4, 2022
    Configuration menu
    Copy the full SHA
    c243cad View commit details
    Browse the repository at this point in the history

  6. ♻️ Maybe a refactor -- but let's explicitly check that it's a Hash … 

    …before trying to see if `@hash_key` is defined
    @danielvdao
    danielvdao committed May 4, 2022
    Configuration menu
    Copy the full SHA
    9c6ff49 View commit details
    Browse the repository at this point in the history

  7. 🔥 remove pry requires

    @danielvdao
    danielvdao committed May 4, 2022
    Configuration menu
    Copy the full SHA
    d494249 View commit details
    Browse the repository at this point in the history

  8. 📝 add comment

    @danielvdao
    danielvdao committed May 4, 2022
    Configuration menu
    Copy the full SHA
    1ec4155 View commit details
    Browse the repository at this point in the history

  9. ⏪ revert back to the original

    @danielvdao
    danielvdao committed May 4, 2022
    Configuration menu
    Copy the full SHA
    cd7f02d View commit details
    Browse the repository at this point in the history