Integrate typing into source #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmartin16
force-pushed
the
integrate-typing
branch
from
b84d0e1
to
6b565aa
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 15 14 -1
Lines 1957 1927 -30
Branches 577 351 -226
==========================================
- Hits 1957 1927 -30
☔ View full report in Codecov by Sentry. |
rmartin16
force-pushed
the
integrate-typing
branch
14 times, most recently
from
0a7c981
to
576dc8b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/qbittorrentapi/request.py
Dismissed
| resp_logger("Request Headers: %s", response.request.headers) | ||
| resp_logger("Request HTTP Data: %s", {"data": data, "params": params}) | ||
| if "auth/login" not in url: | ||
| resp_logger("Request HTTP Data: %s", {"data": data, "params": params}) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
There was a problem hiding this comment.
False positive. Disabled by default and sensitive information from auth/login won't ever be printed.
rmartin16
force-pushed
the
integrate-typing
branch
4 times, most recently
from
75ffd0d
to
a2b15f1
Compare
rmartin16
force-pushed
the
integrate-typing
branch
from
a2b15f1
to
f655ea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
pyifiles in to thepysource filespyiis seemingly much less robust asmypywas much more vigilant about issueshashandhashesarguments for API methods is now unsupported and any uses must be updated to usetorrent_hashandtorrent_hashes, respectively.TypedDict....unfortunately, you cannot useTypedDictwithGenericuntil Python 3.11.AttrDictbase will still cause conflicts...and I'm quite hesitant to rip that out...even if I almost certainly wouldn't have included this if I rewrote all this.