Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Downgrade sphinx version (#1284)" #1378

Merged
merged 1 commit into from May 4, 2020
Merged

Revert "Downgrade sphinx version (#1284)" #1378

merged 1 commit into from May 4, 2020

Conversation

gitanshu
Copy link
Contributor

@gitanshu gitanshu commented May 4, 2020

This reverts commit aabfe20.

The underlying issue was fixed in sphinx 3.0.1

@gitanshu gitanshu requested a review from a team as a code owner May 4, 2020 20:38
@gitanshu gitanshu requested a review from ryanjulian May 4, 2020 20:38
@gitanshu gitanshu requested review from ryanjulian, a team, zequnyu and yonghyuc and removed request for a team May 4, 2020 20:39
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #1378 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1378   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         222      222           
  Lines       11082    11082           
  Branches     1333     1333           
=======================================
+ Hits        10149    10150    +1     
+ Misses        677      675    -2     
- Partials      256      257    +1     
Impacted Files Coverage Δ
.../exploration_strategies/epsilon_greedy_strategy.py 96.29% <0.00%> (-3.71%) ⬇️
src/garage/misc/tensor_utils.py 91.91% <0.00%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e2d65...6148b17. Read the comment docs.

@mergify mergify bot merged commit 0558f21 into master May 4, 2020
@mergify mergify bot deleted the unpin_sphinx branch May 4, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants