Downgrade sphinx version #1284
Merged
Downgrade sphinx version #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two days ago, sphinx doc released a new version, 3.0.0. Unfortunately, there's an issue with it that causes building docs for garage to crash. Until [that issue](sphinx-doc/sphinx#7422) is closed, we need to avoid updating for the CI to work.
gitanshu
approved these changes
Apr 7, 2020
|
For reference, here's an example run of the CI failing: https://travis-ci.com/github/rlworkgroup/garage/jobs/315662150 |
Codecov Report
@@ Coverage Diff @@
## master #1284 +/- ##
=======================================
Coverage 89.04% 89.04%
=======================================
Files 194 194
Lines 9652 9652
Branches 1226 1226
=======================================
Hits 8595 8595
Misses 820 820
Partials 237 237 Continue to review full report at Codecov.
|
|
@Mergifyio backport release-2019.10 |
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2020
Two days ago, sphinx doc released a new version, 3.0.0. Unfortunately, there's an issue with it that causes building docs for garage to crash. Until [that issue](sphinx-doc/sphinx#7422) is closed, we need to avoid updating for the CI to work. (cherry picked from commit aabfe20)
|
Command
|
ryanjulian
pushed a commit
that referenced
this pull request
Apr 8, 2020
Two days ago, sphinx doc released a new version, 3.0.0. Unfortunately, there's an issue with it that causes building docs for garage to crash. Until [that issue](sphinx-doc/sphinx#7422) is closed, we need to avoid updating for the CI to work. (cherry picked from commit aabfe20) Co-authored-by: K.R. Zentner <41180126+krzentner@users.noreply.github.com>
ryanjulian
pushed a commit
that referenced
this pull request
May 4, 2020
This reverts commit aabfe20.
gitanshu
added a commit
that referenced
this pull request
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two days ago, sphinx doc released a new version, 3.0.0.
Unfortunately, there's an issue with it that causes building docs for
garage to crash.
Until that issue is
closed, we need to avoid updating for the CI to work.