Keep migrations consistent after Rails upgrades #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently upgraded a project from Rails v6.1 to v7.0, which changed the default precision for datetime columns from
nil
to6
. PgParty currently callsActiveRecord::ConnectionAdapters::SchemaStatements#create_table
(and#change_column_null
) directly, which doesn't include the backwards compatibility provided byActiveRecord::Migration::Compatibility
. Thus, re-running our existing migrations generated those datetime columns withprecision: 6
instead ofprecision: nil
.This change uses
Proc#binding
/Binding#receiver
to call those methods on theActiveRecord::Migration
instance instead, which includes that backwards compatibility.Thank you!