Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add generic type support to the bootstrap-4 theme #3326

Merged
merged 4 commits into from Jan 5, 2023

Conversation

nickgros
Copy link
Contributor

Based on #3319, partial fix for #3072

  • Adds generic support for Bootstrap 4 theme

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome heath-freenome changed the title fix: Add generic type support to the mui theme fix: Add generic type support to the bootstrap-4 theme Dec 29, 2022
Copy link
Member

@heath-freenome heath-freenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, you forgot to update the main index.ts

import Form from "./Form/Form";

export { default as Form, generateForm } from "./Form";
export { default as Templates, generateTemplates } from "./Templates";
export { default as Theme, generateTheme } from "./Theme";
export { default as Widgets, generateWidgets } from "./Widgets";

export default Form;

@heath-freenome heath-freenome merged commit 51a6517 into rjsf-team:main Jan 5, 2023
shijistar pushed a commit to shijistar/react-jsonschema-form that referenced this pull request Jun 8, 2023
* Generic support for Bootstrap 4
- Partially fix 3072

* Changes from code review

* Changes from code review

Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
shijistar pushed a commit to shijistar/react-jsonschema-form that referenced this pull request Jun 8, 2023
* Generic support for Bootstrap 4
- Partially fix 3072

* Changes from code review

* Changes from code review

Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants