Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isObject should return false for Date as well as File, null, and Array #3292

Merged
merged 6 commits into from Dec 21, 2022
Merged

isObject should return false for Date as well as File, null, and Array #3292

merged 6 commits into from Dec 21, 2022

Commits on Dec 21, 2022

  1. Tests for existing 'isObject' functionality

    @BenBeattieHood
    BenBeattieHood committed Dec 21, 2022
    Copy the full SHA
    d3b092c View commit details
    Browse the repository at this point in the history

  2. isObject should return false for Date as well as File, null, and Array 

    Without this, assigning dates to the form's value instead merges them with a default value for objects of `{}` (in mergeDefaultsWithFormData), which stops them being dates.
    @BenBeattieHood
    BenBeattieHood committed Dec 21, 2022
    Copy the full SHA
    4bb6a1a View commit details
    Browse the repository at this point in the history

  3. Corrected changelog entry

    @BenBeattieHood
    BenBeattieHood committed Dec 21, 2022
    Copy the full SHA
    730a402 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md

    @heath-freenome @BenBeattieHood
    heath-freenome authored and BenBeattieHood committed Dec 21, 2022
    Copy the full SHA
    428903a View commit details
    Browse the repository at this point in the history

  5. Lint formatting tests

    @BenBeattieHood
    BenBeattieHood committed Dec 21, 2022
    Copy the full SHA
    dcac12f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into patch-1

    @heath-freenome
    heath-freenome committed Dec 21, 2022
    Copy the full SHA
    404779f View commit details
    Browse the repository at this point in the history