fix(#3233): fix rendering 0 when there are no errors. #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@suyanhanx Can you please update your PR to fix the tests as well as update the |
|
@suyanhanx We are still waiting for a couple of changes so that we can merge your fix |
|
@heath-freenome Sorry to keep you waiting for so long. I've updated the snapshot and changelog. |
|
@suyanhanx How did you update the snapshot as yours seem to have broken the build. You can simply use |
|
@heath-freenome Well, I did this manually. Now I have used the command you suggested to update snapshots. Thanks for your suggestion. |
heath-freenome
approved these changes
Dec 8, 2022
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
…team#3234) * fix(rjsf-team#3233): fix rendering 0 when there are no errors. * fix: update snapshot and changelog * fix: update snapshot Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
…team#3234) * fix(rjsf-team#3233): fix rendering 0 when there are no errors. * fix: update snapshot and changelog * fix: update snapshot Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fixes #3233
Checklist
npm run test:updateto update snapshots, if needed.