New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect allOf merging (fix #2923) (Reimplement #3025) #3227
Changes from all commits
4d6b292
ad92d83
0555715
4acaa55
a2fe939
88519a3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,7 +54,7 @@ export default function toPathSchema< | |
|
||
if ( | ||
ADDITIONAL_PROPERTIES_KEY in schema && | ||
schema[ADDITIONAL_PROPERTIES_KEY] === true | ||
schema[ADDITIONAL_PROPERTIES_KEY] !== false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We use the path schema to decide which objects to drop when we use |
||
) { | ||
set(pathSchema, RJSF_ADDITONAL_PROPERTIES_FLAG, true); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a test that passes an invalid schema and expects a specific error message. The test fails without this change because a string ends up getting passed here as
rawSchema
, and we don't get to the error case that the test does expect.The best fix would be to actually validate the schema before we get this far, but that would be a large change that would require a lot of effort.