fix: #3189 by allowing the ajv 8 validator to use alternate schema Ajv classes #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ma Ajv classes Fix rjsf-team#3189 by extending the `@rjsf/validator-ajv8` to support the `Ajv2019` and `Ajv2020` classes - Updated the `CustomValidatorOptionsType` to add a new `AjvClass` option - Updated the `createAjvInstance()` function to use the `AjvClass` option is provided to create the `Ajv` class instance, falling back to the default `Ajv` - Updated the `AJV8Validator` to extract the `AjvClass` from the options and pass it to the `createAjvInstance()` function - Updated the tests to also test the `Ajv2019` and `Ajv2020` class instances - Updated the `validation.md` file to document the new `AjvClass` options, switching the examples over to `tsx` - Updated the `CHANGELOG.md` file accordingly
nickgros
approved these changes
Oct 18, 2022
| @@ -394,13 +396,925 @@ describe("AJV8Validator", () => { | |||
| }); | |||
| }); | |||
| }); | |||
| describe("default options, with Ajv2019", () => { | |||
There was a problem hiding this comment.
@heath-freenome
I'm assuming this is all copy/paste with the new class? Let me know if I should take a closer look at this.
There was a problem hiding this comment.
There was one notable change that I commented on, but yeah
heath-freenome
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fix #3189 by extending the
@rjsf/validator-ajv8to support theAjv2019andAjv2020classesCustomValidatorOptionsTypeto add a newAjvClassoptioncreateAjvInstance()function to use theAjvClassoption is provided to create theAjvclass instance, falling back to the defaultAjvAJV8Validatorto extract theAjvClassfrom the options and pass it to thecreateAjvInstance()functionAjv2019andAjv2020class instancesvalidation.mdfile to document the newAjvClassoptions, switching the examples over totsxCHANGELOG.mdfile accordinglyChecklist
npm run test:updateto update snapshots, if needed.