feat: support error list to show at the top or bottom #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacqueswho
requested review from
heath-freenome and
nickgros
and removed request for
heath-freenome
nickgros
reviewed
Oct 13, 2022
heath-freenome
requested changes
Oct 14, 2022
chore: cs check fix: default to top chore: cs-format Update app.jsx Update Form_test.js Update CHANGELOG.md Co-authored-by: Nick Grosenbacher <nickgrosenbacher@gmail.com> Update docs/5.x upgrade guide.md Co-authored-by: Nick Grosenbacher <nickgrosenbacher@gmail.com> chore: changes chore
jacqueswho
force-pushed
the
634-support-showing-the-error-list-at-the-bottom-of-the-form
branch
from
309fee8
to
2bc3167
Compare
heath-freenome
approved these changes
Oct 17, 2022
Fix move of React
heath-freenome
previously approved these changes
Oct 17, 2022
heath-freenome
requested changes
Oct 18, 2022
Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
…-form' of https://github.com/rjsf-team/react-jsonschema-form into 634-support-showing-the-error-list-at-the-bottom-of-the-form
…-form' of https://github.com/rjsf-team/react-jsonschema-form into 634-support-showing-the-error-list-at-the-bottom-of-the-form
heath-freenome
approved these changes
Oct 25, 2022
jacqueswho
deleted the
634-support-showing-the-error-list-at-the-bottom-of-the-form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
If this is related to existing tickets, include links to them as well. Use the syntax fixes #634
Checklist
npm run test:updateto update snapshots, if needed.