Add option to ignore paths when setting watches. #107
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modified version of Zillode#3 and adds (some of) the capability requested in #79. syncthing-inotify uses the mentioned fork with this functionality and it works fine. The main advantage over the status quo (filtering events out after generation) is that this saves watch handles (and is slightly more efficient).
The changes are completely backward compatible. Nothing changes for the existing
Watch
function. The new functionality is included in a new functionWatchWithIgnoring
. This function takes the function variabledoNotWatch
in addition to the usual arguments. This function should return true if given a path (string) that is to be ignored. This is implemented by returning different functions inrecFunc
depending on whetherWatch
(no change) orWatchWithIgnoring
(check doNotWatch at beginning) is used.I would appreciate your feedback.