Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support blake3 hash algo #3030

Merged
merged 1 commit into from Sep 17, 2022
Merged

Support blake3 hash algo #3030

merged 1 commit into from Sep 17, 2022

Conversation

wargio
Copy link
Member

@wargio wargio commented Sep 17, 2022

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Support blake3 algorithm on rizin

XVilka
XVilka approved these changes Sep 17, 2022
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but shouldn't we use a release instead?

@wargio wargio force-pushed the blake3-hash branch 2 times, most recently from e6267fa to cfd3adf Compare September 17, 2022 13:37
@wargio wargio marked this pull request as draft September 17, 2022 13:55
@wargio wargio marked this pull request as ready for review September 17, 2022 14:03
@wargio
Copy link
Member Author

wargio commented Sep 17, 2022

Patch submitted: BLAKE3-team/BLAKE3#261

@wargio wargio merged commit 5b1e5e6 into dev Sep 17, 2022
@wargio wargio deleted the blake3-hash branch September 17, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
API merge-when-green rz-test RzHash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wargio @XVilka