chore(risedev): bump cargo-make version #9366
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
|
Actually, it's added in a patch version of |
risedev
Outdated
| @@ -1,8 +1,8 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| if [ -z "$(which cargo-make)" ]; then | |||
| if [[ $(cargo make --version) != "cargo-make 0.36"* ]]; then | |||
There was a problem hiding this comment.
It's hard to do ">" for semver in bash.
risedev
Outdated
| echo "Installing cargo-make..." | ||
| cargo install cargo-make --version "^0.35" --locked | ||
| cargo install cargo-make --version "^0.36" --locked |
There was a problem hiding this comment.
Should it be
| cargo install cargo-make --version "^0.36" --locked | |
| cargo install cargo-make --version "~0.36" --locked |
?
Because the check is != "cargo-make 0.36"*
|
My honey @BugenZhao, I think it's good enough, although occasionally breaks 😇. If you really want to fix it, I think we should also consider how to manage versions for e.g., |
|
BTW, cargo make supports installing dependencies and specifying versions https://github.com/sagiegurari/cargo-make#defining-version 🤔 |
|
Use instaed |
This is really cool. 🫡 Thank you, my sweet @xxchan. |
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Codecov Report
@@ Coverage Diff @@
## main #9366 +/- ##
==========================================
- Coverage 70.79% 70.79% -0.01%
==========================================
Files 1227 1227
Lines 203447 203447
==========================================
- Hits 144039 144038 -1
- Misses 59408 59409 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
For example, changes introduced in #9006 use a recent functionality
files_modified" ofcargo-make`.Checklist For Contributors
./risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note