Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine lifetime for rotate_last_mut #6193

Merged
merged 2 commits into from Nov 3, 2022
Merged

chore: refine lifetime for rotate_last_mut #6193

merged 2 commits into from Nov 3, 2022

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Nov 3, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

For rotate_last_mut only apply for &self.buffers, restricting the lifetime of the closure parameter &mut Vec<_> to outlive the &mut self parameter of the function is okay.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#5119
#6025

@MrCroxx MrCroxx self-assigned this Nov 3, 2022
@MrCroxx MrCroxx added mergify/can-merge Indicates that the PR can be added to the merge queue and removed mergify/can-merge Indicates that the PR can be added to the merge queue labels Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #6193 (1b01ddb) into main (912db57) will decrease coverage by 0.11%.
The diff coverage is 60.44%.

@@            Coverage Diff             @@
##             main    #6193      +/-   ##
==========================================
- Coverage   74.36%   74.25%   -0.12%     
==========================================
  Files         935      940       +5     
  Lines      150096   151208    +1112     
==========================================
+ Hits       111612   112272     +660     
- Misses      38484    38936     +452     
Flag Coverage Δ
rust 74.25% <60.44%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/optimizer/plan_node/plan_base.rs 96.96% <0.00%> (-3.04%) ⬇️
.../frontend/src/optimizer/plan_node/stream_derive.rs 0.00% <0.00%> (ø)
src/meta/src/lib.rs 0.96% <ø> (+0.03%) ⬆️
src/storage/src/hummock/file_cache/cache.rs 90.76% <0.00%> (-0.85%) ⬇️
src/storage/src/hummock/mod.rs 54.97% <0.00%> (-2.22%) ⬇️
src/stream/src/executor/mod.rs 48.32% <ø> (ø)
src/stream/src/from_proto/mod.rs 0.00% <ø> (ø)
src/stream/src/from_proto/sort.rs 0.00% <0.00%> (ø)
src/frontend/src/optimizer/plan_node/stream.rs 13.55% <13.95%> (-0.57%) ⬇️
src/storage/src/hummock/file_cache/store.rs 89.84% <40.00%> (-1.89%) ⬇️
... and 40 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Nov 3, 2022
@mergify mergify bot merged commit f49b2d7 into main Nov 3, 2022
@mergify mergify bot deleted the xx/lifetime branch November 3, 2022 16:08
mergify bot added a commit that referenced this pull request Nov 3, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@BugenZhao
Copy link
Member

Why are there 2 commits on the main branch? 🤣

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Nov 4, 2022

Why are there 2 commits on the main branch? 🤣

Confused. 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants