Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix warnings on latest clippy #5876

Merged
merged 2 commits into from Oct 17, 2022
Merged

style: fix warnings on latest clippy #5876

merged 2 commits into from Oct 17, 2022

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Oct 17, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

picked from #5119

@xxchan xxchan added the mergify/can-merge Indicates that the PR can be added to the merge queue label Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #5876 (98cc624) into main (0f0e6c5) will decrease coverage by 0.17%.
The diff coverage is 40.38%.

@@            Coverage Diff             @@
##             main    #5876      +/-   ##
==========================================
- Coverage   75.09%   74.92%   -0.18%     
==========================================
  Files         920      921       +1     
  Lines      145144   145701     +557     
==========================================
+ Hits       108996   109162     +166     
- Misses      36148    36539     +391     
Flag Coverage Δ
rust 74.92% <40.38%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/hop_window.rs 69.10% <0.00%> (-0.57%) ⬇️
src/batch/src/executor/join/lookup_join.rs 58.05% <0.00%> (ø)
src/common/src/types/ordered_float.rs 29.70% <0.00%> (-0.20%) ⬇️
...c/connector/src/source/nexmark/source/generator.rs 0.00% <ø> (ø)
src/ctl/src/cmd_impl/hummock/compaction_group.rs 0.00% <0.00%> (ø)
src/ctl/src/lib.rs 0.92% <0.00%> (-0.49%) ⬇️
src/expr/src/expr/expr_binary_nonnull.rs 79.25% <0.00%> (-2.22%) ⬇️
src/expr/src/vector_op/arithmetic_op.rs 47.67% <0.00%> (-4.64%) ⬇️
src/frontend/src/lib.rs 40.00% <0.00%> (-3.48%) ⬇️
...frontend/src/optimizer/plan_node/batch_sort_agg.rs 75.60% <0.00%> (+1.80%) ⬆️
... and 78 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xxchan xxchan requested a review from BugenZhao October 17, 2022 07:54
@mergify mergify bot merged commit a00021f into main Oct 17, 2022
@mergify mergify bot deleted the xxchan/exuberant-cod branch October 17, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants