-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(scale): introduce deterministic scaling tests #5657
Merged
Merged
Changes from 10 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
2fa5c9c
initial scale sim
BugenZhao ffd39db
test q4
BugenZhao d3b75ff
locate fragment
BugenZhao d30b66c
fix predicate & add cascade
BugenZhao 08e61b1
add docs
BugenZhao 53d222f
add workflows
BugenZhao 9183918
add license header
BugenZhao 99cd61a
fix workflow
BugenZhao 6743964
fix ci & add cfg madsim
BugenZhao b7861bc
try use ci-sim
BugenZhao 8e89c8c
align cfg with sslt
BugenZhao d887c4e
align with sslt
BugenZhao 62703bb
correct result & soft fail
BugenZhao 821012c
do not use shared mem store
BugenZhao f68b67b
Merge remote-tracking branch 'origin/main' into bz/scale-sim
BugenZhao 9baad0e
avoid hard coded thoughput
BugenZhao c1d8bba
use ci-sim profile
BugenZhao aa96954
remove comments
BugenZhao f88edfa
fix connector
BugenZhao c2ab7ba
increase opt level for ci-sim
BugenZhao 4d1ee73
remove stream workaround
BugenZhao 21df22d
fix clippy
BugenZhao b68306b
minor fixes
BugenZhao e275e05
bump futures to 0.3.24
BugenZhao 1870972
Merge branch 'main' into bz/scale-sim
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#!/bin/bash | ||
|
||
# Exits as soon as any line fails. | ||
set -euo pipefail | ||
|
||
source ci/scripts/common.env.sh | ||
|
||
echo "--- Download artifacts" | ||
buildkite-agent artifact download scale-test.tar.zst . | ||
|
||
echo "--- Run scaling tests in deterministic simulation mode" | ||
MADSIM_TEST_NUM=5 cargo nextest run --archive-file scale-test.tar.zst --no-fail-fast |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ | |
use std::time::{SystemTime, UNIX_EPOCH}; | ||
|
||
use anyhow::{Ok, Result}; | ||
use futures::future::pending; | ||
use futures_async_stream::try_stream; | ||
use risingwave_common::bail; | ||
|
||
|
@@ -43,7 +44,12 @@ impl NexmarkEventGenerator { | |
#[try_stream(ok = Vec<SourceMessage>, error = anyhow::Error)] | ||
pub async fn into_stream(mut self) { | ||
loop { | ||
yield self.next().await? | ||
let chunk = self.next().await?; | ||
if chunk.is_empty() { | ||
yield pending().await; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could be CPU intensive if there are no remaining records to generate, which is problematic with madsim. 🤣 |
||
} else { | ||
yield chunk; | ||
} | ||
} | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
[package] | ||
name = "risingwave_simulation_scale" | ||
version = "0.1.0" | ||
edition = "2021" | ||
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | ||
|
||
[dependencies] | ||
anyhow = "1.0" | ||
async-trait = "0.1" | ||
clap = "3" | ||
futures = { version = "0.3", default-features = false, features = ["alloc"] } | ||
glob = "0.3" | ||
itertools = "0.10" | ||
madsim = "0.2.7" | ||
rand = "0.8" | ||
risingwave_compactor = { path = "../../storage/compactor" } | ||
risingwave_compute = { path = "../../compute" } | ||
risingwave_ctl = { path = "../../ctl" } | ||
risingwave_frontend = { path = "../../frontend" } | ||
risingwave_meta = { path = "../../meta" } | ||
risingwave_pb = { path = "../../prost" } | ||
sqllogictest = "0.6.4" | ||
tempfile = "3" | ||
tokio = { version = "0.2", package = "madsim-tokio" } | ||
tokio-postgres = "0.7.7" | ||
tracing = "0.1" | ||
|
||
[target.'cfg(not(madsim))'.dependencies] | ||
workspace-hack = { version = "0.1", path = "../../workspace-hack" } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer merging it into the existing simulation crate, maybe in a future PR.