Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump madsim #16760

Closed
wants to merge 2 commits into from
Closed

build: bump madsim #16760

wants to merge 2 commits into from

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented May 15, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

I'm thinking whether #15722 (comment) is related with madsim

test_serving_cluster_availability�[0m�[35;1m ---�[0m
thread '<unnamed>' panicked at src/tests/simulation/tests/integration_tests/batch/mod.rs:138:31:
called `Result::unwrap_err()` on an `Ok` value:

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan xxchan requested a review from a team as a code owner May 15, 2024 03:20
Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan
Copy link
Member Author

xxchan commented May 15, 2024

cc @wangrunji0408 @zwang28

@xxchan
Copy link
Member Author

xxchan commented May 15, 2024

BTW, madsim cannot compile with async-channel@2.3.0

@wangrunji0408
Copy link
Contributor

I'm afraid we need to bisect madsim version between 0.22 and 0.27. 🥵

@xxchan
Copy link
Member Author

xxchan commented May 15, 2024

I guess it's possibly related with sleep? BTW, @zwang28 pushed a new commit to change the test in #15722

@wangrunji0408
Copy link
Contributor

cc @zwang28 Do you confirm the root cause of the failure? Wondering if it was simply caused by a different random number generated.

@xxchan xxchan closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants