Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling rework #393

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

comradekingu
Copy link

Markup, escaping and capitalization might be a bit off

@azul
Copy link
Contributor

azul commented Feb 9, 2018

Hi @comradekingu ,

Thanks a lot for your fixes. Very helpful.
I spotted one formatting issue. Will comment in line.

config/en.yml Outdated
cookie_disabled_warning: You have cookies disabled. You will not be able to login
until you enable cookies.
email_verification_body: |-
congratulations_you_have_signed_up: "Congratulations! You have signed up for %{site_title}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotation marks " include the following line in this translation. But the cookie_disabled_warning is a separate string all together.

config/en.yml Outdated
congratulations_you_have_signed_up: "Congratulations! You have signed up for %{site_title}.
cookie_disabled_warning: You have cookies disabled. You will not be able to log in
until you enable cookies."
email_verification_body: "|-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need quotes here. The |- already is yaml syntax for a multi line value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants