feat!: implement Python wrappers for the full Rust API #230

Shadow53 · 2023-01-09T23:43:52Z

Resolves #208.

This does not include tests for the new Python stuff, but no clippy lints are triggered. There are changes made to the Rust crate in order to make this work, but everything should just work as before.

crates/lib/src/api.rs

crates/lib/src/configuration/mod.rs

crates/lib/src/executable.rs

crates/lib/src/execution_data.rs

crates/lib/src/lib.rs

crates/lib/src/qvm/execution.rs

crates/python/src/api.rs

crates/python/src/executable.rs

jselig-rigetti

Overall looks great!

We should merge the rigetti-pyo3:support-fieldless-enums-data-structs branch first, right?
Do we still need to hand-write the .pyi files?

crates/lib/src/api.rs

crates/python/Cargo.toml

crates/python/src/register_data.rs

crates/python/src/api.rs

crates/python/src/qpu/client.rs

crates/python/src/executable.rs

MarquessV

This is a big PR, so I'll take another pass later, but looking good so far. I would make sure we use conventional commits to properly call out breaking changes. I called out one on an enum, but it looks like there are others related to the shift to Cow

crates/lib/src/api.rs

Shadow53 · 2023-01-10T22:09:59Z

From @jselig-rigetti:

We should merge the rigetti-pyo3:support-fieldless-enums-data-structs branch first, right?

Correct.

Do we still need to hand-write the .pyi files?

I think so. This issue is still open. The #[args()] attribute sets __text_signature__, which is helpful, but not the same as type stubs.

From @MarquessV:

I would make sure we use conventional commits to properly call out breaking changes.

I've revised commit messages to include the ! to indicate breaking changes.

…Python

crates/python/src/api.rs

kalzoo

Aside from the version bump following upstream PR, this meets the bar to merge. Noting, of course, that we're about to break just about every function in the Python bindings once @MarquessV 's Program changes land.

crates/lib/src/api.rs

crates/python/src/lib.rs

crates/python/src/api.rs

MarquessV

Looks good!

refactor(lib): remove unused module

a712312

Shadow53 requested review from MarquessV, kalzoo and jselig-rigetti January 9, 2023 23:43

Shadow53 force-pushed the 208-return-pyo3-types branch from 0ebbf3a to 7053746 Compare January 10, 2023 00:36

Shadow53 commented Jan 10, 2023

View reviewed changes

crates/python/src/executable.rs Show resolved Hide resolved

jselig-rigetti reviewed Jan 10, 2023

View reviewed changes

MarquessV reviewed Jan 10, 2023

View reviewed changes

crates/lib/src/api.rs Outdated Show resolved Hide resolved

Shadow53 added 11 commits January 10, 2023 14:11

refactor(lib)!: use num::Complex instead of custom typedef

47bf6e0

chore(lib): remove newly removed lint

8a68b83

refactor(lib)!: use Cow<str> instead of &str for execution

fd97469

style(lib): resolve clippy lints

c2879aa

feat(python): start directly wrapping types from the Rust SDK

aa729d1

refactor(lib)!: replace Box<str> -> String, &str -> Cow<str>

dbbc6e3

feat(python): wrap more types for Python

87a39e1

feat(python): add missing wrappers for remaining types

6ad951b

refactor(python): change how Complex64ReadoutValues converts to/from …

d1cf077

…Python

chore(python): use rigetti-pyo3 from git, not local path

e847da7

feat(python): define default arguments to methods

1ae1298

Shadow53 force-pushed the 208-return-pyo3-types branch from 7053746 to 1ae1298 Compare January 10, 2023 22:11

jselig-rigetti reviewed Jan 12, 2023

View reviewed changes

crates/python/src/api.rs Show resolved Hide resolved

Shadow53 added 2 commits January 23, 2023 11:50

doc(lib): explain seeming type disagreement

ef9a28e

refactor(python): simplify code, remove TODO

5600581

kalzoo approved these changes Jan 23, 2023

View reviewed changes

crates/lib/src/api.rs Outdated Show resolved Hide resolved

crates/python/src/lib.rs Outdated Show resolved Hide resolved

crates/python/src/api.rs Show resolved Hide resolved

Shadow53 added 4 commits January 23, 2023 16:09

chore(python): remove unnecessary comments

bfda07d

refactor(lib): avoid confusion by changing Complex32 -> Complex<f32>

258a664

chore(python): bump minimum python version to 3.8

94c5a99

chore(python): bump rigetti-pyo3

11002e2

Shadow53 added 4 commits January 23, 2023 17:07

chore(python): gitignore __pycache__

b9c91f3

chore(lib): update tokio, disable unused warp features

2babc4d

test(python): fix failing test

208919c

chore(python): run poetry update

4c4167d

MarquessV approved these changes Jan 24, 2023

View reviewed changes

Shadow53 changed the title ~~feat: implement Python wrappers for the full Rust API~~ feat!: implement Python wrappers for the full Rust API Jan 24, 2023

Shadow53 merged commit bb063c7 into main Jan 24, 2023

Shadow53 deleted the 208-return-pyo3-types branch January 24, 2023 19:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: implement Python wrappers for the full Rust API #230

feat!: implement Python wrappers for the full Rust API #230

Shadow53 commented Jan 9, 2023 •

edited

jselig-rigetti left a comment •

edited

MarquessV left a comment •

edited

Shadow53 commented Jan 10, 2023 •

edited

kalzoo left a comment

MarquessV left a comment

feat!: implement Python wrappers for the full Rust API #230

feat!: implement Python wrappers for the full Rust API #230

Conversation

Shadow53 commented Jan 9, 2023 • edited

jselig-rigetti left a comment • edited

Choose a reason for hiding this comment

MarquessV left a comment • edited

Choose a reason for hiding this comment

Shadow53 commented Jan 10, 2023 • edited

kalzoo left a comment

Choose a reason for hiding this comment

MarquessV left a comment

Choose a reason for hiding this comment

Shadow53 commented Jan 9, 2023 •

edited

jselig-rigetti left a comment •

edited

MarquessV left a comment •

edited

Shadow53 commented Jan 10, 2023 •

edited