feat: add support for setting '24h' as end work hour #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me. Once you fix the test I'll merge it. |
FlorianLoch
force-pushed
the
improve-set-work-hours
branch
from
f119f93
to
50dd21a
Compare
|
Ouch, that was a remnant of my first approach that must have slipped through... Anyway, should be fixed now :) |
|
Failing tests should be resolved, you might want to give the test job another run 😉 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it should be possible to configure "till end of day" using
24husingSetWorkHours()in combination withIsWorkTime().Until now using
24hfailed (silently) because by applying module it drops to0and thereforeIsWorkTImealways returns false. Code using it that way basically is broken.Therefore, this also should not affect backwards compatibility.
WDYT?