Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bulgarian holidays #114

Merged

Conversation

DanailPenev
Copy link
Contributor

Summary

  • This PR adds support for Bulgarian holidays, in line with other existing regions

Interesting difference

  • The only interesting difference is that Bulgaria celebrates Orthodox Easter which can sometimes happen in early May
  • Bulgaria also celebrates Labour Day on 1st May. When Labour Day is on the Saturday/Sunday right after Good Friday, the government moves Labour Day to Tuesday (instead of the Monday as per the usual rules)
  • To accommodate for that, there is a special inline func that determines whether Labour Day should be observed on Monday or Tuesday

Tests

  • Added tests for years 2018-2023.
  • The government changed the observance rules in 2017 so it is expected that any dates before 2017 will not be accurate.

@DanailPenev
Copy link
Contributor Author

@rickar please let me know if there is anything I've missed. 🙏

@rickar rickar merged commit 5cbae22 into rickar:master Apr 5, 2023
2 checks passed
@rickar
Copy link
Owner

rickar commented Apr 5, 2023

Looks good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants