Skip to content

Commit

Permalink
chore: Upgrade rubocop 0.73 -> 1.3 for TestHelpers
Browse files Browse the repository at this point in the history
The Style/BracesAroundHashParameters was removed from Rubocop.
See the following issue for more info:
rubocop/rubocop#7641
  • Loading branch information
richardmcmillen committed Oct 24, 2022
1 parent 18bfd39 commit aa576f3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
2 changes: 0 additions & 2 deletions test_helpers/.rubocop.yml
Expand Up @@ -16,5 +16,3 @@ Naming/FileName:
- "lib/opentelemetry-test-helpers.rb"
Style/ModuleFunction:
Enabled: false
Style/BracesAroundHashParameters:
Enabled: false
6 changes: 2 additions & 4 deletions test_helpers/lib/opentelemetry/test_helpers.rb
Expand Up @@ -55,11 +55,9 @@ def with_env(new_env)
keys_to_delete.each { |k| ENV.delete(k) }
end

def with_ids(trace_id, span_id)
def with_ids(trace_id, span_id, &block)
OpenTelemetry::Trace.stub(:generate_trace_id, trace_id) do
OpenTelemetry::Trace.stub(:generate_span_id, span_id) do
yield
end
OpenTelemetry::Trace.stub(:generate_span_id, span_id, &block)
end
end

Expand Down
2 changes: 1 addition & 1 deletion test_helpers/opentelemetry-test-helpers.gemspec
Expand Up @@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'pry'
spec.add_development_dependency 'pry-byebug' unless RUBY_ENGINE == 'jruby'
spec.add_development_dependency 'rake', '~> 12.0'
spec.add_development_dependency 'rubocop', '~> 0.73.0'
spec.add_development_dependency 'rubocop', '~> 1.3'
spec.add_development_dependency 'simplecov', '~> 0.17'
spec.add_development_dependency 'yard', '~> 0.9'
spec.add_development_dependency 'yard-doctest', '~> 0.1.6'
Expand Down

0 comments on commit aa576f3

Please sign in to comment.