Make name property of enum cases return non-empty-strings (vimeo#6964)

ricardoboss · Dec 5, 2021 · 2ec77fe · 2ec77fe
1 parent 056497e
commit 2ec77fe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/AtomicPropertyFetchAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/AtomicPropertyFetchAnalyzer.php
@@ -202,7 +202,7 @@ public static function analyze(
                         new Type\Union([new Type\Atomic\TLiteralString($lhs_type_part->case_name)])
                     );
                 } else {
-                    $statements_analyzer->node_data->setType($stmt, Type::getString());
+                    $statements_analyzer->node_data->setType($stmt, Type::getNonEmptyString());
                 }
             } else {
                 self::handleNonExistentProperty(

diff --git a/tests/EnumTest.php b/tests/EnumTest.php
@@ -126,6 +126,9 @@ enum Status
                         case PUBLISHED;
                         case ARCHIVED;
 
+                        /**
+                         * @return non-empty-string
+                         */
                         public function get(): string
                         {
                             return $this->name;