Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to mitigate CVE #44

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Update dependencies to mitigate CVE #44

merged 1 commit into from
Apr 30, 2018

Conversation

rdebeasi
Copy link
Contributor

@rdebeasi rdebeasi commented Apr 27, 2018

hoek 4.2.0 and earlier are vulnerable to a prototype pollution attack. This PR brings in a minor update to request, which now uses hoek 4.2.1 instead of 4.2.0. (See this line in pakage-lock.json for confirmation of the version number.)

GitHub will still complain about 4.2.1, but this is apparently a false positive. Only 4.2.0 and earlier are affected.

[rdebeasi@rdebeasi infographic]$ npm ls hoek
infographic@1.0.0 /home/rdebeasi/Projects/infographic
└─┬ request@2.85.0
  └─┬ hawk@6.0.2
    ├─┬ boom@4.3.1
    │ └── hoek@4.2.1  deduped
    ├─┬ cryptiles@3.1.2
    │ └─┬ boom@5.2.0
    │   └── hoek@4.2.1  deduped
    ├── hoek@4.2.1 
    └─┬ sntp@2.1.0
      └── hoek@4.2.1  deduped

CC @oybed

@oybed oybed self-requested a review April 30, 2018 12:56
@oybed oybed added the bug label Apr 30, 2018
Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oybed oybed merged commit 3d2382b into rht-labs:master Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants