Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to go v1.22 #483

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

bump to go v1.22 #483

wants to merge 6 commits into from

Conversation

jan--f
Copy link
Collaborator

@jan--f jan--f commented May 14, 2024

No description provided.

Bumps [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) from 0.29.3 to 0.30.0.
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.29.3...v0.30.0)

---
updated-dependencies:
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@jan--f jan--f requested a review from a team as a code owner May 14, 2024 18:52
@jan--f jan--f requested review from slashpai and JoaoBraveCoding and removed request for a team May 14, 2024 18:52
Copy link

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jan--f jan--f force-pushed the go-1.22 branch 2 times, most recently from 8ec7144 to 65407a9 Compare May 16, 2024 12:15
This fixes our current ci issues. Seems like some dependencies have
updated to go1.22 and operator-sdk generate is not backwards compatible.
kubernetes-sigs/controller-runtime#2720 has
some details.

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
With the go1.22 update and controller-runtime 0.17.x the project doesn't
build.

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Also update kind version and kind-action version.

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Copy link

openshift-ci bot commented May 16, 2024

@jan--f: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 686f120 link true /test images
ci/prow/observability-operator-e2e 686f120 link true /test observability-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@marioferh marioferh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jan--f
Copy link
Collaborator Author

jan--f commented May 23, 2024

/hold
waiting for cachito to support 1.22 vendoring. https://issues.redhat.com/browse/STONEBLD-2206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants