ci: rename commitlint.config.js to commitlint.config.mjs #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan--f
requested review from
danielmellado and
JoaoBraveCoding
and removed request for
a team
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
And update commitlint action to v6. This fixes commitlint failures caused by wagoid/commitlint-github-action#763. Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f
force-pushed
the
fix-commitlint-action-cfg-extension
branch
from
bdaf30a
to
9d2f6eb
Compare
There was a problem hiding this comment.
We would need to change module.exports to export default Configuration; in here to comply with the ES module syntax.
There was a problem hiding this comment.
yeah, I think that should make it.
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
|
/lgtm |
| @@ -9,4 +9,4 @@ const Configuration = { | |||
| ignores: [(msg) => /Signed-off-by: dependabot\[bot]/m.test(msg)], | |||
| }; | |||
|
|
|||
| module.exports = Configuration; | |||
| export default Configuration | |||
There was a problem hiding this comment.
Suggested change
| export default Configuration | |
| export default Configuration; |
There was a problem hiding this comment.
let's keep the end trailing even if it does seem that it works without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes commitlint failures caused by
wagoid/commitlint-github-action#763.