feat: restrict UIPlugin CRD names to allow a single instance per type

[jgbernalp]

OU-402
COO-164

This PR adds a pattern restriction for the UIPlugin name so only a single instance of a specific plugin is allowed

[jan--f]

/lgtm

Nice! We'll have to chat about OCP specific integration tests soon.

[simonpasquier]

AFAIU you can still create conflicting objects if you mess up the names and the types, right? For instance:

apiVersion: observability.openshift.io/v1alpha1
kind: UIPlugin
metadata:
  name: ui-dashboards
spec:
  type: Dashboards
---
apiVersion: observability.openshift.io/v1alpha1
kind: UIPlugin
metadata:
  name: ui-logging
spec:
  type: Dashboards

I don't think that it's possible to validate this case with OpenAPI but we might want the operator to stop reconciliation when it detects the issue?

[jan--f]

Ahh I think I might have been (or still am) confused what needs to be done. So there can always only be a single dashboard UI plugin? An for logging a new type is added, going by #477?

In that case can we not tie the name to the type? Something like

// +kubebuilder:validation:XValidation:rule="self.name == self.spec.type",message="Name is invalid"

[simonpasquier]

@jan--f this would be neat if it works indeed.

[jgbernalp]

Will do some tests based on @jan--f suggestion and update the PR

[xperimental]

Just a nitpick, but I think I would get rid of the ui- prefix for the names. First it mirrors the name of the resource type (UIPlugin) and it also currently causes the deployments to be named observability-ui-ui-* (which could be changed in the operator though).

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jgbernalp
Once this PR has been reviewed and has the lgtm label, please ask for approval from jan--f. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jgbernalp]

/hold

@csibbitt please check if changes are needed for STF

[simonpasquier]

/lgtm
/hold

👍

[csibbitt]

/hold

@csibbitt please check if changes are needed for STF

STF does not use the UIPlugin, but Telemetry Operator does. I'll take care of this ASAP on OSPRH-7600