-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ppc64le/multi-arch support for observability-operator #413
base: main
Are you sure you want to change the base?
Conversation
Hi @jcho02. Thanks for your PR. I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
$(CONTAINER_RUNTIME) push $(BUNDLE_IMG)-amd64 | ||
$(CONTAINER_RUNTIME) push $(BUNDLE_IMG)-ppc64le |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer the image push stays in the push target. Is this needed to build the manifest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes if we're using Podman, we can't build and push in one command for Podman multi-arch builds like Docker
$(CONTAINER_RUNTIME) push ${OPERATOR_IMG}-amd64 | ||
$(CONTAINER_RUNTIME) push ${OPERATOR_IMG}-ppc64le |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here as for the bundle image. Do we have to push images in the build step? If not strictly necessary I'd prefer to keep build and push separate.
Makefile.tools
Outdated
jq: | ||
@{ \ | ||
set -ex ;\ | ||
sudo apt-get install jq ;\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We keep the tool installs distro agnostic. and apt install won't work on my machine. Let's either install this like the other tools or add a gate that checks for presence and errors out if it's not in the PATH
hack/build.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually used anywhere? If not the skopeo
dependency can also be dropped iiuc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a bash script if users want to build all three operator, bundle, and catalog images in one command. I used it for dev purposes if you want to keep it, but its not necessary.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jcho02 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jason Cho <jason.cho2@ibm.com>
Signed-off-by: Jason Cho <jason.cho2@ibm.com>
Rebased from close #308