Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppc64le/multi-arch support for observability-operator #413

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jcho02
Copy link

@jcho02 jcho02 commented Jan 30, 2024

Rebased from close #308

@jcho02 jcho02 requested a review from a team as a code owner January 30, 2024 15:45
@jcho02 jcho02 requested review from jan--f and sthaha and removed request for a team January 30, 2024 15:45
Copy link

openshift-ci bot commented Jan 30, 2024

Hi @jcho02. Thanks for your PR.

I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from slashpai January 30, 2024 15:46
@jcho02
Copy link
Author

jcho02 commented Jan 30, 2024

@danielmellado

Makefile Outdated Show resolved Hide resolved
Makefile.tools Outdated Show resolved Hide resolved
Comment on lines +209 to +210
$(CONTAINER_RUNTIME) push $(BUNDLE_IMG)-amd64
$(CONTAINER_RUNTIME) push $(BUNDLE_IMG)-ppc64le
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer the image push stays in the push target. Is this needed to build the manifest?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes if we're using Podman, we can't build and push in one command for Podman multi-arch builds like Docker

Comment on lines +141 to +142
$(CONTAINER_RUNTIME) push ${OPERATOR_IMG}-amd64
$(CONTAINER_RUNTIME) push ${OPERATOR_IMG}-ppc64le
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here as for the bundle image. Do we have to push images in the build step? If not strictly necessary I'd prefer to keep build and push separate.

Makefile.tools Outdated
jq:
@{ \
set -ex ;\
sudo apt-get install jq ;\
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We keep the tool installs distro agnostic. and apt install won't work on my machine. Let's either install this like the other tools or add a gate that checks for presence and errors out if it's not in the PATH

hack/build.sh Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually used anywhere? If not the skopeo dependency can also be dropped iiuc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a bash script if users want to build all three operator, bundle, and catalog images in one command. I used it for dev purposes if you want to keep it, but its not necessary.

Copy link

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcho02
Once this PR has been reviewed and has the lgtm label, please ask for approval from jan--f. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Jason Cho <jason.cho2@ibm.com>
Signed-off-by: Jason Cho <jason.cho2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants