Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhobs-logs] Disable tracing to temporarily stop panic errors #284

Merged
merged 1 commit into from
Jul 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/services/observatorium-logs-template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,7 @@ objects:
"addresses": "dns+observatorium-loki-index-query-cache.${NAMESPACE}.svc.cluster.local:11211"
"consistent_hash": true
"tracing":
"enabled": true
"enabled": false
overrides.yaml: '{}'
kind: ConfigMap
metadata:
Expand Down
9 changes: 8 additions & 1 deletion services/observatorium-logs.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,14 @@ local lokiCaches = (import 'components/loki-caches.libsonnet');
max_global_streams_per_user: 25000,
},
tracing: {
enabled: true,
// TODO(@periklis):
// Re-enable jaeger tracing of Loki once both issues fixed:
// - https://github.com/grafana/loki/issues/6667
// - https://github.com/weaveworks/common/pull/246
// Currently collecting the user id and org id in exemplar
// when Loki is sampled by jaeger fails with a golang panic:
// `http: panic serving : exemplar labels have 87 runes, exceeding the limit of 64`
enabled: false,
},
},
}),
Expand Down