Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x/sys to fix OSX compatibility #239

Merged
merged 2 commits into from Jun 13, 2022

Conversation

esnible
Copy link
Contributor

@esnible esnible commented Jun 10, 2022

Signed-off-by: Ed Snible snible@us.ibm.com

Resolves #238

The fix is basically these three commands from the .bingo directory:

go get -modfile=jsonnet.mod -u golang.org/x/sys
go get -modfile=jsonnetfmt.mod -u golang.org/x/sys
go get -modfile=gojq.mod -u golang.org/x/sys

Note that this repo doesn't check in the .sum files. I am in the habit of checking them in for Go (see https://stackoverflow.com/questions/53837919/should-go-sum-file-be-checked-in-to-the-git-repository ), but I don't know Bingo conventions do I did not check them in here.

Signed-off-by: Ed Snible <snible@us.ibm.com>
@douglascamata
Copy link
Member

@esnible according to thanos-io/thanos#5392 (comment), you can add the .sum files that were updated to the PR.

Signed-off-by: Ed Snible <snible@us.ibm.com>
@esnible
Copy link
Contributor Author

esnible commented Jun 10, 2022

Updated to include the .sum files.

Copy link
Member

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matej-g matej-g merged commit ac136e1 into rhobs:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build problems on MacOS under Go 1.18
3 participants