Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set shorter workflow timeouts #3016

Merged
merged 1 commit into from Nov 25, 2020

Conversation

martinpitt
Copy link
Contributor

The default timeout is 6 hours, which just causes unnecessary hangs,
delays, and blocked self-hosted runners if anything goes wrong (such as
pylint-dev/pylint#3899).

A normal run takes about 10 minutes, so set a timeout of 30 minutes.
Use one hour for the full container rebuild+validation+upload to be on
the safe side (it usually takes between 15 and 18 minutes).

The default timeout is 6 hours, which just causes unnecessary hangs,
delays, and blocked self-hosted runners if anything goes wrong (such as
pylint-dev/pylint#3899).

A normal run takes about 10 minutes, so set a timeout of 30 minutes.
Use one hour for the full container rebuild+validation+upload to be on
the safe side (it usually takes between 15 and 18 minutes).
Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@martinpitt martinpitt merged commit 16b9b0b into rhinstaller:master Nov 25, 2020
@martinpitt martinpitt deleted the test-timeouts branch November 25, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants