Hostname handling

[adamkankovsky]

[adamkankovsky]

Updated to new design

[rvykydal]

I'd hate to slow down this PR but I'd consider using "network information" instead of "DHCP" as if I understand it correctly it can be set also just from DNS lookup, independently of DHCP (https://www.freedesktop.org/wiki/Software/systemd/hostnamed/ )?

Other than that I am fine with the design for this PR, thank you.

[rvykydal]

If I change a value from empty/transient to something, then I am not able to change it back to empty/transient. I think we should allow this (and add to tests if so).

[rvykydal]

Looks good to me with minor issues I would not block on, but I think we should allow to reset to transient.

[rvykydal]

I can't understand "not starting or ending a label"

[adamkankovsky]

If I change a value from empty/transient to something, then I am not able to change it back to empty/transient. I think we should allow this (and add to tests if so).

Unfortunately there is a bit of a problem here, because Anaconda doesn't allow you to set an empty hostname, so it won't be possible to fix this without modifying the backend.

[rvykydal]

I'd hate to slow down this PR but I'd consider using "network information" instead of "DHCP" as if I understand it correctly it can be set also just from DNS lookup, independently of DHCP (https://www.freedesktop.org/wiki/Software/systemd/hostnamed/ )?

Other than that I am fine with the design for this PR, thank you.

@garrett what do you think?

[rvykydal]

If I change a value from empty/transient to something, then I am not able to change it back to empty/transient. I think we should allow this (and add to tests if so).

Unfortunately there is a bit of a problem here, because Anaconda doesn't allow you to set an empty hostname, so it won't be possible to fix this without modifying the backend.

Hm, I've checked with rawhide that it is possible with the Gtk UI: set it in the entry of Network Spoke to a value, empty string, and then a value again - the value will propagate in the backend on leaving the Network spoke. Also setting empty hostname is possible. There will be empty /etc/hostname on target system.

[adamkankovsky]

If I change a value from empty/transient to something, then I am not able to change it back to empty/transient. I think we should allow this (and add to tests if so).

Unfortunately there is a bit of a problem here, because Anaconda doesn't allow you to set an empty hostname, so it won't be possible to fix this without modifying the backend.

Hm, I've checked with rawhide that it is possible with the Gtk UI: set it in the entry of Network Spoke to a value, empty string, and then a value again - the value will propagate in the backend on leaving the Network spoke. Also setting empty hostname is possible. There will be empty /etc/hostname on target system.

@rvykydal So I finally modified the regex to allow empty hostnames and added tests to test it.

[KKoukiou]

these changes are unrelated and add noise to the commit. Please avoid code-reorganization in feature commits.

[KKoukiou]

I split out the hostname related code to seperate component and file for readability purposes. Also the groupping of the description elements should be seperate commit for the same purpose.

Obsolete